Changeset d8b9ff8 in iPeer


Ignore:
Timestamp:
2013-08-28T15:15:06-07:00 (4 years ago)
Author:
Compass <pan.luo@…>
Branches:
3.1.x, dev, master
Children:
4e93757
Parents:
3ccd390
git-author:
mwytang <michael.tang@…> (07/03/2013 09:46:08 AM)
git-committer:
Compass <pan.luo@…> (08/28/2013 03:15:06 PM)
Message:

Fixed mixed evaluation results for scoredropdown questions

If the instructor chose to only display basic results, scoredropdown
results would not be displayed. On the contrary if grades are not
released in the detail view (students) scoredropdown results will
still appear. This bug has now been fixed by grouping scoredropdown
questions with the other graded questions (Likert) when doing
question type checking.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • app/views/elements/evaluations/mixeval_details.ctp

    r3ccd390 rd8b9ff8  
    2727            echo '<ul>';
    2828            foreach ($ques['Submissions'] as $num => $sub) {
    29                 if ($type == '1' && !$gradeReleased) {
     29                if (in_array($type, array(1, 4)) && !$gradeReleased) {
    3030                    echo '<li>'._t('Grades Not Released Yet').'</li>';
    3131                    break;
     
    7070    echo '<br>';
    7171} else {
    72     foreach ($questions as $ques) {
    73         if ($ques['self_eval'] == $peer_eval) {
    74             continue; // skip questions not in the desired section
    75         }
    76         if ($ques['mixeval_question_type_id'] == '1') {
     72    foreach ($questions as $qnum => $ques) {
     73        $typeId = $ques['mixeval_question_type_id'];
     74        if ($typeId == '1' || $type == '4') {
    7775            $required = (!$ques['required']) ? '' :
    7876                $html->tag('span', '*', array('class' => 'required orangered'));
Note: See TracChangeset for help on using the changeset viewer.